hi Laxman,

I believe the context of your patch is:

https://discuss.96boards.org/t/snapdragon820-recovery-package-for-emmc-storage/5945/2

I suspect this change would break QDL on DB820c, so you are probably
not testing on DB820c... I agree that we need a mechanism to set
MemoryName to either ufs or emmc, instead of hardcoding it here so
that we can support both DB820c and 820 boards with eMMC... Do you
think you can write up a patch that has a new argument to configure
memory to be emmc or ufs and share with everyone?

Just copy/pasting your patch for others to have a look.

>From 655bafe23ac4a9ad33bfe3ad8caa8be5e771a71c Mon Sep 17 00:00:00 2001
From: laxman <laxman@inforcecomputing.com>
Date: Fri, 2 Nov 2018 11:44:40 +0530
Subject: [PATCH] qdl:support for emmc based boards

qdl for emmc storage

Signed-off-by: laxman <laxman@inforcecomputing.com>
---
 firehose.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/firehose.c b/firehose.c
index c4e9500..027264f 100644
--- a/firehose.c
+++ b/firehose.c
@@ -277,7 +277,7 @@ static int firehose_send_configure(int fd, size_t
payload_size, bool skip_storag
  xmlDocSetRootElement(doc, root);

  node = xmlNewChild(root, NULL, (xmlChar*)"configure", NULL);
- xml_setpropf(node, "MemoryName", "ufs");
+ xml_setpropf(node, "MemoryName", "emmc");
  xml_setpropf(node, "MaxPayloadSizeToTargetInBytes", "%d", payload_size);
  xml_setpropf(node, "verbose", "%d", 0);
  xml_setpropf(node, "ZLPAwareHost", "%d", 0);
--
2.7.4
On Fri, Nov 2, 2018 at 7:41 AM laxman siripuram <itsmelaxman91@gmail.com> wrote:
>
> Hi,
> Added qdl support for emmc storage based devices. It is validated on sd660/sd820 chipset boards based on emmc storage.
>
>
> Regards,
> Laxman
> _______________________________________________
> dragonboard mailing list
> dragonboard@lists.96boards.org
> https://lists.96boards.org/mailman/listinfo/dragonboard