[Dev] [PATCH 1/2] dts: hi6220: use readable setting for gpio range

Daniel Thompson daniel.thompson at linaro.org
Thu Apr 16 09:01:42 UTC 2015


On 15/04/15 13:14, Leo Yan wrote:
> Signed-off-by: Leo Yan <leo.yan at linaro.org>

Would like to see a comment here.

The patch could easily be divorced from the cover letter if we end up 
with a delay upstreaming these changes. Then there is more work needed 
to rediscover what the patch is for.


> ---
>   arch/arm64/boot/dts/hi6220.dtsi | 32 ++++++++++++++++++++++++--------
>   1 file changed, 24 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/hi6220.dtsi b/arch/arm64/boot/dts/hi6220.dtsi
> index 2f7f8a1..e882dcc 100644
> --- a/arch/arm64/boot/dts/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hi6220.dtsi
> @@ -300,15 +300,31 @@
>   			pinctrl-single,register-width = <32>;
>   			pinctrl-single,function-mask = <7>;
>   			pinctrl-single,gpio-range = <
> -				&range 0  1  1
> -				&range 2  24  1
> -				&range 28  8  1
> -				&range 43  21  1
> -				&range 74  6  1
> -				&range 80  42  0
> -				&range 122  1  1
> -				&range 126  33  1
> +				&range  80  8 0 /* gpio  3: [0..7] */
> +				&range  88  8 0 /* gpio  4: [0..7] */
> +				&range  96  8 0 /* gpio  5: [0..7] */
> +				&range 104  8 0 /* gpio  6: [0..7] */
> +				&range 112  8 0 /* gpio  7: [0..7] */
> +				&range 120  2 0 /* gpio  8: [0..1] */
> +				&range   2  6 1 /* gpio  8: [2..7] */
> +				&range   8  8 1 /* gpio  9: [0..7] */
> +				&range   0  1 1 /* gpio 10: [0]    */
> +				&range  16  7 1 /* gpio 10: [1..7] */
> +				&range  23  3 1 /* gpio 11: [0..2] */
> +				&range  28  5 1 /* gpio 11: [3..7] */
> +				&range  33  3 1 /* gpio 12: [0..2] */
> +				&range  43  5 1 /* gpio 12: [3..7] */
> +				&range  48  8 1 /* gpio 13: [0..7] */
> +				&range  56  8 1 /* gpio 14: [0..7] */
> +				&range  74  6 1 /* gpio 15: [0..5] */
> +				&range 122  1 1 /* gpio 15: [6]    */
> +				&range 126  1 1 /* gpio 15: [7]    */
> +				&range 127  8 1 /* gpio 16: [0..7] */
> +				&range 135  8 1 /* gpio 17: [0..7] */
> +				&range 143  8 1 /* gpio 18: [0..7] */
> +				&range 151  8 1 /* gpio 19: [0..7] */

Does this refactor old stuff and add new stuff in the same patch?

If so might be better for this to be two patches (where first one tidies 
up but makes no functional change).






More information about the Dev mailing list