Re: [Dev] Standardizing LED labels and triggers for 96Boards

Hi Linus,

On Thu, Sep 06, 2018 at 12:11:53PM +0200, Linus Walleij wrote:

On Mon, Sep 3, 2018 at 5:55 PM Manivannan Sadhasivam manivannan.sadhasivam@linaro.org wrote:

...

1. We have MMC and SATA triggers but no UFS trigger AFAIK. So, boards

implementing UFS storage will not use LED 2.

The generic disk activity trigger is usually registered. I guess this is because UFS lives in SCSI and SCSI does not call ledtrig_disk_activity() when stuff happens on a SCSI device.

Yes.

ATA and IDE does... I think it's just a matter of patching something inside drivers/scsi/* and it should work fine with UFS too. It should have been done ages ago, just noone did it.

I would do it if I had a SCSI or UFS system running but I don't.

Makes sense! Will look into it along with this patchseries.

Thanks, Mani

Yours, Linus Walleij