Hi Haojian,
On 17 March 2015 at 13:36, Haojian Zhuang haojian.zhuang@linaro.org wrote:
On 17 March 2015 at 17:59, Mark Brown broonie@kernel.org wrote:
On Tue, Mar 17, 2015 at 09:04:43AM +0000, Haojian Zhuang wrote:
+static void disable_boot(struct dw_mci *host) +{
int timeout = 0;
unsigned int data;
mci_writel(host, CTRL, SDMMC_CTRL_FIFO_RESET);
mci_writel(host, CMD, SDMMC_CMD_START | SDMMC_CMD_DISABLE_BOOT);
while (1) {
data = mci_readl(host, CMD) & 0x80000000;
if (data == 0)
break;
This looks like something generic which other systems might be able to use and not specific to the HiSilicon SoC - does this belong in either the Designware code or the subsystem code?
But I have neither Designware spec nor designware code. I only got this code from Hisilicon.
Could any guy help to check whether this piece of code is in original designware code?
At this 96boards list we can test patches on hikey and provide general mainlining advice. I think the right people to discuss the clean way to implement this are the linux-mmc@vger.kernel.org mailing list, where chances are some people with access to designware docs are able to answer.
For Ulf, since Mark clipped most of the patch, the full patch discussed is at:
https://lists.96boards.org/pipermail/dev/2015-March/000092.html
Riku