On 26/03/15 17:48, Jorge Ramirez-Ortiz wrote:
On 03/26/2015 11:15 AM, Scott Bambrough wrote:
I've been going around with Jorge for a couple of days with this. He doesn't see the error but I do using make 4.0. I have spoken with Vishal and he sees this error with make 3.81, and tells me Fathi sees this error in local builds.
Works for me with GNU Make 3.81 on Ubuntu 12.04. I didn't remove anything from Kbuild in the patch I sent you as I didn't hit this issue, but the bit of logic involved only tends to make sense when the driver is built out-of-tree. So in this context I think it can be simplified as Scott suggested (i.e. by removing the license test) as we know it's all GPL.
on my side it builds fine (I havent been able to reproduce the error using the following)
[jramirez@calypso-2 ~]$ cat /etc/lsb-release DISTRIB_ID=Ubuntu DISTRIB_RELEASE=14.04 DISTRIB_CODENAME=trusty DISTRIB_DESCRIPTION="Ubuntu 14.04.2 LTS"
[jramirez@calypso-2 ~]$ make -v GNU Make 3.81 Copyright (C) 2006 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
This program built for x86_64-pc-linux-gnu
and [jramirez@calypso ~]$ cat /etc/lsb-release DISTRIB_ID=Ubuntu DISTRIB_RELEASE=14.10 DISTRIB_CODENAME=utopic DISTRIB_DESCRIPTION="Ubuntu 14.10"
[jramirez@calypso ~]$ make -v GNU Make 4.0 Built for x86_64-pc-linux-gnu Copyright (C) 1988-2013 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later http://gnu.org/licenses/gpl.html This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law.
-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590 ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782