On Thu, May 12, 2016 at 1:54 AM, David Long firstname.lastname@example.org wrote:
On 05/11/2016 03:52 PM, Jorge Ramirez wrote:
On 05/11/2016 01:32 PM, John Stultz wrote:
On Wed, May 11, 2016 at 6:38 AM, David Long email@example.com wrote:
On Tue, May 10, 2016 at 4:24 PM, Guodong Xu firstname.lastname@example.org wrote:
> > On 05/09/2016 06:56 PM, John Stultz wrote: >> >> Ok. I've got this running against 4.4 now and it seems to be working >> ok. I'll be submitting it for review for AOSP, and will make sure >> Guodong is cc'ed so he can pick it up in his branches. >>
Thanks, guys. So this feature is now part of hikey-mainline-rebase (v4.4).
If hikey is to work with unmodified upstream code doesn't someone (KWG/Me?) have to make this "hack" (which is in the common USB driver) more palatable?
Yea. There's still enough less controversial functionality to get upstream to keep folks busy, but eventually we will get down to the few hardware specific quirks like this that we need to solve in a generic fashion (hikey's restricted HDMI modes is another similar quirk). To some extent it will depend on the maintainers desire to accommodate such a quirk.
having said that nothing should discourage you to improve the code David
- this and some other fixes/workarounds were not planned activities if
that is what you are asking, just some hours spent after work (I have the feeling that you are asking about having a proper process in place to deal with issues like this?)
I'm just looking to help convert local fixes to known problems into acceptable upstream patches (in core code). I don't want to be duplicating work someone else is already doing or necessarily starting with the lowest priority issues, but this is a documented limitation where we might be able to take an existing quick fix and turn it into something acceptable upstream. I'm only looking at it now because I personally ran into it as a regression. I'm not sure if the current USB items in the gantt chart cover this issue, and someone could certainly tell me different core changes need to be upstreamed first. Do feel free to point out any process I might be missing here.
IMHO getting this fixed properly upstream is desirable and someone should spend time on it. The are some other tasks around hdmi audio that need help. Just pick one and let Guodong know.